- 18 Nov, 2016 19 commits
-
-
Flavio Santes authored
This commit fixes an issue in the test_ccm_mode.c file: sizeof(data) is used to compute the length of the array pointed to by the 'uint8_t *data' pointer. At the same function scope, there is a variable (dlen) that already specifies the required length, so we use that variable instead of the 'sizeof' function call. This issue was not reported by Coverity, although is worth to fix it. Change-Id: I27cbf8c7000a4189a42d193f6445996d4b852aa6 Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Flavio Santes authored
This commit fixes the wrong sizeof argument error reported by Coverity. Coverity-CID: 152032 Change-Id: I2ee3089b4b840f4a1b8ba0303e92a3311c07ffeb Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Flavio Santes authored
This commit fixes the dead code issue reported by Coverity. Coverity-CID: 151977 Change-Id: Iaa31c032456f48e1af1d1c9d722f051ac5519ccf Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Flavio Santes authored
This commit fixes the dead code issue reported by Coverity. Coverity-CID: 151975 Change-Id: I449341d1f540abe149e8ad9197a64d52cd5722cd Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Benjamin Walsh authored
There was no check to see if the head of a list was empty before trying to fetch the next node in the list. The fix is added to sys_dlist_peek_next() so that it also return NULL if the node parameter is NULL, in addition to being the tail of the list. Since the value is not used until the second iteration of the loop, and there will be no second iteration if the list is empty, as long as the CPU does allow reading at address 0, this was not causing any issues. Our ARC targets did not seem to like that. Fixes ZEP-1263 and ZEP-1297. Change-Id: I07ca16592d206d13662226d1249f487ee78c06aa Signed-off-by:
Benjamin Walsh <walsh.benj@gmail.com>
-
Flavio Santes authored
Fix the issue reported by Coverity: wrong sizeof argument. Coverity-CID: 152042 Change-Id: I5d593ba54bf8f69f3c9d41a8b2878827d1cc186a Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Anas Nashif authored
NANOKERNEL is obsolete and this kernel service is still using it causing deperecaton warnings. Move it to POST_KERNEL Change-Id: I17fabd080645f93a8599f4ea25da844e1ec5f4bb Signed-off-by:
Anas Nashif <anas.nashif@intel.com>
-
Anas Nashif authored
This reverts commit 608abd98 . This change is breaking build dependencies. Change-Id: Id8e9dbfc14b72933c402d25847615cddbfaca40d Jira: ZEP-1291 Signed-off-by:
Anas Nashif <anas.nashif@intel.com>
-
Jithu Joseph authored
This fixes a string overflow past the end of a buffer which was reported by coverity. Coverity-CID: 152044 Change-Id: I5b331135e338fa43b5589a9488b06367e8cad5a7 Signed-off-by:
Jithu Joseph <jithu.joseph@intel.com>
-
Baohong Liu authored
The variable type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: If26c881d207a6cedc52b7589c5d7ebb2040c7ab7 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
The variable type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: I92ca14b7a2c0507a86a6b6abaa567a5091622ad1 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
The memcmp is a comparison between two strings or buffers. So, the length should be the buffer length, not the length of the pointer to the buffer. This was caught by LLVM. Jira: ZEP-1179 Change-Id: I7fd6b199686b19e7f4a2e1288897483e69ad091e Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
This variable type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: I891dc9d55055292e6a749f300e995798040d0b24 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Jithu Joseph authored
This commit fixes a missing function return check reported by Coverity. Coverity-CID: 151949 Change-Id: Iedf090b7f2ded9f20ff6d796f1cd5c02990b0a4e Signed-off-by:
Jithu Joseph <jithu.joseph@intel.com>
-
Sergio Rodriguez authored
Exiting from the test case when the gpio device is not found, this to avoid a null pointer dereference This issue was reported by Coverity Coverity-CID: 151980 Change-Id: I44f13131d44c7c093781e1f11f8481e7ef8175c9 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Baohong Liu authored
A popular issue "format is not a string literally" was caught by LLVM. Let's make it a string literally. Jira: ZEP-1179 Change-Id: I2b4a5aef750b772504bf0e6f005dab2ff9ac3e7c Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Sergio Rodriguez authored
Exiting from the test case when the gpio device is not found, this to avoid a null pointer dereference This issue was reported by Coverity Coverity-CID: 151982 Change-Id: Ifaed47b2b48359dacfdb3111ca2895d5912779e6 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Baohong Liu authored
The enum type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: I50b68e201ef6fb18a02eeda2a2e7548dad3f358c Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
Add function return value check. This was caught by Coverity. Coverity-CID: 151950 Change-Id: Iee550e15d124f05f0b0514fdad22d06c617beac2 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
- 17 Nov, 2016 8 commits
-
-
Benjamin Walsh authored
There was a possible race condition when setting the return value of a thread that is pending, from an ISR. A kernel function causes a thread to pend, with the following series of steps: - disable interrupts - move current thread to wait_q - call _Swap Depending if running on M3/4 or M0+, _Swap will either issue a svc #0, or pend PendSV directly. The same problem exists in both cases. M3/4: __svc will: - enable interrupts - trigger __pendsv M0+: _Swap() will enable interrupts. __pendsv will: - save register context including PSP into the thread struct If an interrupt occurs between interrupts being enabled them and __pendsv saving PSP, and the ISR sets the pending thread's return value, this will happen: - sees the thread in a wait_q - removes it - makes it ready - calls _set_thread_return_value - _set_thread_return_value looks at the thread's saved PSP to poke the value In this scenario, PSP hasn't yet been updated by __pendsv so...
-
Sergio Rodriguez authored
The data structure member being used is character array, dereferencig this array gives **char instead of the expected *char type. This issue was reported by Coverity Coverity-CID: 152030 Coverity-CID: 152033 Change-Id: Ied67e4b2d47017e6ad5e40b9b6fca1b496c483ed Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Sergio Rodriguez authored
This fixes an always false evaluation of the gpio I/O direction This issue was reported by Coverity (CID 150821). Change-Id: I6c0e9fe405cbd3e35454a81754fa0b1c721691f0 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Sergio Rodriguez authored
This fixes an always false evaluation of the gpio I/O direction This issue was reported by Coverity Coverity-CID: 151833 Change-Id: Ie952d6f50c0383d5631325b69e8e8b234c67c4b8 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Sergio Rodriguez authored
This fixes an always false evaluation of the gpio I/O direction This issue was reported by Coverity Coverity-CID: 151834 Change-Id: I033e368b2e91d888f2e8a797490df757513c3906 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Flavio Santes authored
The sensor_channel_get return code is now evaluated. Change-Id: Ib931d6caba65af7195bad53c62e6e5a3033b49e8 Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Flavio Santes authored
sensor_sample_fetch return code is now evaluated. Coverity-CID: 151957 Change-Id: I79b9f44c79ac13e8d7da55c9e3866ad504a4a450 Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Luiz Augusto von Dentz authored
This fixes defect found by coverity: 152027 Pointer to local outside scope. Change-Id: I50f196a04363ffa6e6654b71a9a1d89034580413 Signed-off-by:
Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
-
- 16 Nov, 2016 13 commits
-
-
Allan Stephens authored
Replaces confusing (and excessively long) configuration option names with more intuitive names. Also enhances the description of each option to clarify its use. Change-Id: If4d4541407627482b1e90302cfc9df3bc8130d44 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Change-Id: Ib5e5aa14534af4789d8247e6096913e09731f5bb Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
* Ensures all references to kernel functions are correctly tagged so they will auto-link to the API guide. * Adds references to a few functions and macros that were omitted. Change-Id: I26ccd9c29ea123db2807f2df4d05d574932c6849 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Most kernel APIs are now ready for inclusion in the API guide. The APIs largely follow a standard template to provide users of the API guide with a consistent look-and-feel. Change-Id: Ib682c31f912e19f5f6d8545d74c5f675b1741058 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Iván Briano authored
Jira: ZEP-1287 Change-Id: I3678631aa5843e769b8e1611734767fa6264b9af Signed-off-by:
Iván Briano <ivan.briano@intel.com>
-
Vincenzo Frascino authored
This patch fixes an unreachable code condition in the uart_console driver. If UART_CONSOLE_DEBUG_SERVER_HOOKS was not defined handled_by_debug_server in console_out was always 0. This issue was reported by Coverity (CID 131627). Change-Id: I4376c3e5b3e68220218df6aabd91b6a8900ca31f Signed-off-by:
Vincenzo Frascino <vincenzo.frascino@linaro.org>
-
Vincenzo Frascino authored
This patch fixes two "Unchecked return value" conditions into the bma280 driver. The issue was reported by Coverity (CID 151953). Change-Id: I2e595b67619411594cec527f358f6c3d3d034550 Signed-off-by:
Vincenzo Frascino <vincenzo.frascino@linaro.org>
-
Sergio Rodriguez authored
This issue was reported by Coverity (CID 151952) Change-Id: I59a20a3ccbe606ef634db98ac6cc6889a3973ec3 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Sergio Rodriguez authored
This fixes an uninitialized pointer being pass and evaluated by a subsequent function This issue was reported by Coverity (CID 150824) Change-Id: If1f636a44cc675b56e426b1de85895b74ba7105e Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Johan Hedberg authored
Using the K_* macros makes it easier to read what exactly the various timeouts are. Change-Id: Ia405d3760b8e600af7e33a7221ef6ec717708973 Signed-off-by:
Johan Hedberg <johan.hedberg@intel.com>
-
Vinayak Chettimada authored
Change-id: I7b691d082d080239c35b63221e3c6c7aa93ed58e Signed-off-by:
Vinayak Chettimada <vinayak.kariappa.chettimada@nordicsemi.no>
-
Vinayak Chettimada authored
External interrupts are indexed from value 16, wherein 0 to 15 are ARM cortex M exceptions. Fixed code in _irq_is_priority_equal to fetch correct external interrupt line ISR priority. Change-id: I9cfd411480e78dfc9635e72d14df9d667a9d8400 Signed-off-by:
Vinayak Chettimada <vinayak.kariappa.chettimada@nordicsemi.no>
-
Ramesh Thomas authored
testcase.ini was not building for ARC. This app would run on x86 and arc. Change-Id: I961d56079aa1db7d84e0fcc87780ba11d7f4d831 Signed-off-by:
Ramesh Thomas <ramesh.thomas@intel.com>
-