- 18 Nov, 2016 37 commits
-
-
Anas Nashif authored
Change-Id: I6b3f07714322ad79aeec2342621a4cddfe84cb2c Signed-off-by:
Anas Nashif <anas.nashif@intel.com>
-
Paul Sokolovsky authored
Pinmux driver almost certainly should be initialized before the rest of hardware devices (which may need specific pins already configured for them), and usually after generic GPIO drivers. Thus, its priority should be between KERNEL_INIT_PRIORITY_DEFAULT (default 40) and KERNEL_INIT_PRIORITY_DEVICE (default 50). Thus, we set PINMUX_INIT_PRIORITY to 45. There are exceptions to the rule above for particular boards. For example, BOARD=galileo has GPIO and pinmuxer on I2C bus and thus overrides PINMUX_INIT_PRIORITY to be much higher. Note that while PINMUX_INIT_PRIORITY was defined previously (at 60), it was used only for galileo, which overrides it anyway. This fix was prompted by investigation why eth_ksdk driver was non-functional after kernel priorities re-hashing: both eth_ksdk and pinmux used the same priority, and eth_ksdk happened to run before pinmux. While bumping eth_ksdk priority would help in the particular case, the same would likely reoccur with other drivers like I2C, SPI, etc. Change-Id: Ie5ca3135c1ee2fe8d9cf48d5c12e62eac63487f7 Signed-off-by:
Paul Sokolovsky <paul.sokolovsky@linaro.org>
-
Inaky Perez-Gonzalez authored
By default, when a 'fatal fault' message is seen in the output of any testcase, it is consider an inmediate fatal condition and the test case is aborted. However, in all such cases, the testcase is provoking the situation to verify the condition is caught. In this case it shall NOT be considered a fatal fault and the default overriden to allow it to proceed. Change-Id: Id4e9138e5f0fcb8cd77efbb1831897fb0946ba20 Signed-off-by:
Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> (cherry picked from commit da5f3a5c)
-
Allan Stephens authored
Change-Id: Ie989b45b19e5e70958301dd8d903cf2876709f5a Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Also fixes up Kernel Primer examples to use these macros. Change-Id: Ib1bc9e3f85ab75f81986bc3930fb287266a886b5 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Rewrites the example of a timer's expiry routine offloading processing that can't be done at interrupt level. The example now submits work to the system workqueue directly, rather than using an alert. This saves footprint by eliminating the need for alert-related API support that isn't needed. (This is a true savings, since the alert code just called the same workqueue APIs the example now calls directly.) Change-Id: I378e40aef33014f2c75c4f57531f75247d50e479 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Change-Id: I82453c1fb5365d7dfe35cb1bc9eba50c71a47b17 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Change-Id: I5ea1bd28f355d78c724948568c160ef1b32b5eb5 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Return value descriptions using the "@retval" tag now reflect the fact that they appear on a separate line from the value they are describing. Change-Id: I3e3e347d133ad998e7db50a99369d41cbfb9efcc Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
The API guide now does a better job of explaining how to use a workqueue. Also hides information about workqueue internals and fixes several errors and omissions. Change-Id: I6492c1c6105c258ce98365ca33059d8f32c1be41 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
The API guide now does a better job of explaining how to correctly write these functions. Change-Id: Ib1df55eb28fa408f3f786f122353e37505002f07 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Allan Stephens authored
Also adds a link to function-type API that was missing. Change-Id: Ie671ad2f239cdca3ac1a2eb33248dfecfa251c79 Signed-off-by:
Allan Stephens <allan.stephens@windriver.com>
-
Baohong Liu authored
Proceed to LCD programming only if device binding succeeds. Otherwise, dereferencing a NULL pointer will happen. This was caught by Coverity. Coverity-CID: 151986 Change-Id: Ibdb658f530203428aa3e53f358e0788fc1502b06 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Javier B Perez authored
Coverity detected some constant value in the vars, due to the exclusive config select in the code. Change-Id: Id27b658f3cd70dce626fef054457a9c726b3b957 CID: 151974, 151972 and 151971 Signed-off-by:
Javier B Perez <javier.b.perez.hernandez@intel.com>
-
Sergio Rodriguez authored
This fixes an always false evaluation of the gpio I/O direction This issue was reported by Coverity Coverity-CID: 151978 Change-Id: I93ec3319a3f18d564c961a5cbd9dcc9c60efbeb7 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Sergio Rodriguez authored
The GPIO_INT_ACTIVE_LOW value is zero so the mask assignement is never executed. Using the bit complement GPIO_INT_ACTIVE_HIGH the proper mask is assigned This issue was reported by Coverity Coverity-CID: 151966 Change-Id: Ibc7d2e4c3ebee249b5ab9719f8177cc14c0d1d33 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Sergio Rodriguez authored
The bitfield determining the I/O direction already defines the pin as either input or output, cannot be none or both at the same time This issue was reported by Coverity Coverity-CID: 151970 Change-Id: I18d5387139d6834004ba3269c5b54176bdc97ea7 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Baohong Liu authored
Stop the app from running if device binding fails. Otherwise, dereferencing NULL pointer will happen. This was caught by Coverity. Coverity-CID: 151988 Change-Id: I8245d938498a51123249fbd069935900ad660314 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Flavio Santes authored
This commit fixes an issue in the test_ccm_mode.c file: sizeof(data) is used to compute the length of the array pointed to by the 'uint8_t *data' pointer. At the same function scope, there is a variable (dlen) that already specifies the required length, so we use that variable instead of the 'sizeof' function call. This issue was not reported by Coverity, although is worth to fix it. Change-Id: I27cbf8c7000a4189a42d193f6445996d4b852aa6 Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Flavio Santes authored
This commit fixes the wrong sizeof argument error reported by Coverity. Coverity-CID: 152032 Change-Id: I2ee3089b4b840f4a1b8ba0303e92a3311c07ffeb Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Flavio Santes authored
This commit fixes the dead code issue reported by Coverity. Coverity-CID: 151977 Change-Id: Iaa31c032456f48e1af1d1c9d722f051ac5519ccf Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Flavio Santes authored
This commit fixes the dead code issue reported by Coverity. Coverity-CID: 151975 Change-Id: I449341d1f540abe149e8ad9197a64d52cd5722cd Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Benjamin Walsh authored
There was no check to see if the head of a list was empty before trying to fetch the next node in the list. The fix is added to sys_dlist_peek_next() so that it also return NULL if the node parameter is NULL, in addition to being the tail of the list. Since the value is not used until the second iteration of the loop, and there will be no second iteration if the list is empty, as long as the CPU does allow reading at address 0, this was not causing any issues. Our ARC targets did not seem to like that. Fixes ZEP-1263 and ZEP-1297. Change-Id: I07ca16592d206d13662226d1249f487ee78c06aa Signed-off-by:
Benjamin Walsh <walsh.benj@gmail.com>
-
Flavio Santes authored
Fix the issue reported by Coverity: wrong sizeof argument. Coverity-CID: 152042 Change-Id: I5d593ba54bf8f69f3c9d41a8b2878827d1cc186a Signed-off-by:
Flavio Santes <flavio.santes@intel.com>
-
Anas Nashif authored
NANOKERNEL is obsolete and this kernel service is still using it causing deperecaton warnings. Move it to POST_KERNEL Change-Id: I17fabd080645f93a8599f4ea25da844e1ec5f4bb Signed-off-by:
Anas Nashif <anas.nashif@intel.com>
-
Anas Nashif authored
This reverts commit 608abd98 . This change is breaking build dependencies. Change-Id: Id8e9dbfc14b72933c402d25847615cddbfaca40d Jira: ZEP-1291 Signed-off-by:
Anas Nashif <anas.nashif@intel.com>
-
Jithu Joseph authored
This fixes a string overflow past the end of a buffer which was reported by coverity. Coverity-CID: 152044 Change-Id: I5b331135e338fa43b5589a9488b06367e8cad5a7 Signed-off-by:
Jithu Joseph <jithu.joseph@intel.com>
-
Baohong Liu authored
The variable type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: If26c881d207a6cedc52b7589c5d7ebb2040c7ab7 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
The variable type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: I92ca14b7a2c0507a86a6b6abaa567a5091622ad1 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
The memcmp is a comparison between two strings or buffers. So, the length should be the buffer length, not the length of the pointer to the buffer. This was caught by LLVM. Jira: ZEP-1179 Change-Id: I7fd6b199686b19e7f4a2e1288897483e69ad091e Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
This variable type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: I891dc9d55055292e6a749f300e995798040d0b24 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Jithu Joseph authored
This commit fixes a missing function return check reported by Coverity. Coverity-CID: 151949 Change-Id: Iedf090b7f2ded9f20ff6d796f1cd5c02990b0a4e Signed-off-by:
Jithu Joseph <jithu.joseph@intel.com>
-
Sergio Rodriguez authored
Exiting from the test case when the gpio device is not found, this to avoid a null pointer dereference This issue was reported by Coverity Coverity-CID: 151980 Change-Id: I44f13131d44c7c093781e1f11f8481e7ef8175c9 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Baohong Liu authored
A popular issue "format is not a string literally" was caught by LLVM. Let's make it a string literally. Jira: ZEP-1179 Change-Id: I2b4a5aef750b772504bf0e6f005dab2ff9ac3e7c Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Sergio Rodriguez authored
Exiting from the test case when the gpio device is not found, this to avoid a null pointer dereference This issue was reported by Coverity Coverity-CID: 151982 Change-Id: Ifaed47b2b48359dacfdb3111ca2895d5912779e6 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Baohong Liu authored
The enum type mismatching was caught by LLVM. Jira: ZEP-1179 Change-Id: I50b68e201ef6fb18a02eeda2a2e7548dad3f358c Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
Baohong Liu authored
Add function return value check. This was caught by Coverity. Coverity-CID: 151950 Change-Id: Iee550e15d124f05f0b0514fdad22d06c617beac2 Signed-off-by:
Baohong Liu <baohong.liu@intel.com>
-
- 17 Nov, 2016 3 commits
-
-
Benjamin Walsh authored
There was a possible race condition when setting the return value of a thread that is pending, from an ISR. A kernel function causes a thread to pend, with the following series of steps: - disable interrupts - move current thread to wait_q - call _Swap Depending if running on M3/4 or M0+, _Swap will either issue a svc #0, or pend PendSV directly. The same problem exists in both cases. M3/4: __svc will: - enable interrupts - trigger __pendsv M0+: _Swap() will enable interrupts. __pendsv will: - save register context including PSP into the thread struct If an interrupt occurs between interrupts being enabled them and __pendsv saving PSP, and the ISR sets the pending thread's return value, this will happen: - sees the thread in a wait_q - removes it - makes it ready - calls _set_thread_return_value - _set_thread_return_value looks at the thread's saved PSP to poke the value In this scenario, PSP hasn't yet been updated by __pendsv so...
-
Sergio Rodriguez authored
The data structure member being used is character array, dereferencig this array gives **char instead of the expected *char type. This issue was reported by Coverity Coverity-CID: 152030 Coverity-CID: 152033 Change-Id: Ied67e4b2d47017e6ad5e40b9b6fca1b496c483ed Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-
Sergio Rodriguez authored
This fixes an always false evaluation of the gpio I/O direction This issue was reported by Coverity (CID 150821). Change-Id: I6c0e9fe405cbd3e35454a81754fa0b1c721691f0 Signed-off-by:
Sergio Rodriguez <sergio.sf.rodriguez@intel.com>
-